On Fri, May 20, 2011 at 03:11:35PM -0500, Doug Goldstein wrote:
On Thu, May 19, 2011 at 6:24 AM, Daniel P. Berrange <berrange@redhat.com> wrote:
Sanlock is a project that implements a disk-paxos locking algorithm. This is suitable for cluster deployments with shared storage.
* src/Makefile.am: Add dlopen plugin for sanlock * src/locking/lock_driver_sanlock.c: Sanlock driver --- libvirt.spec.in | 11 + po/POTFILES.in | 1 + src/Makefile.am | 12 + src/libvirt_private.syms | 1 + src/locking/lock_driver_sanlock.c | 413 +++++++++++++++++++++++++++++++++++++ 5 files changed, 438 insertions(+), 0 deletions(-) create mode 100644 src/locking/lock_driver_sanlock.c
<snip>
Daniel,
How does the dependency magic for sanlock work here? It appears that there will be an automagical dependency on libsanlock when its installed. It might be a good idea to provide a ./configure script knob to enable/disable this piece.
That was waiting for sanlock to provide a pkgconfig file...
Additionally, I see you've added virAllocVar to the syms list but I don't see it used anywhere else in the context of this patch. Not sure if I'm missing something.
It is used in sanlock.c: + if (VIR_ALLOC_VAR(res, struct sanlk_disk, 1) < 0) { + virReportOOMError(); + return -1; + } Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|