Re: [libvirt] [PATCH] qemudDomainCreate check if domain is already active
On Thu, Jul 24, 2008 at 12:49:13AM -0400, Guido Günther wrote:
Hi,
currently virsh create foo.xml overwrites running domains. In case of
qemu this leaves detached qemu processes around and the domain creation
fails later on being unable to start other domains afterwards - not
nice.
Attached patch checks if we already have a running domain by that name
and in this case refuses to create a new domain from xml by that name.
okay looks fine to me
Probably this check needs to be pushed further upward since this
might
affect other hypervisors too, haven't checked that though.
Well for Xen that check is delegated to xend, and in general it's better
to keep it that way to avoid potential races. I guess the problem is
more likely for hypervisors where libvirt(d) runs a process to control the
domain and where there is no central checking done.
OpenVZ and LXC should be checked for that, yes.
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/