Re: [libvirt] [PATCH] storage: fix incorrect typedef

On Tue, Oct 29, 2013 at 10:00:17AM -0600, Eric Blake wrote: > The rbd code had a confusing typedef ending in Ptr that was not > actually a pointer, which made the rest of the code harder to > read. This fixes things to actually pass by pointer rather than > by copy. > > * src/storage/storage_backend_rbd.c (virStorageBackendStatePtr): > Fix typedef. > (virStorageBackendRBDOpenRADOSConn) > (virStorageBackendRBDCloseRADOSConn) > (volStorageBackendRBDRefreshVolInfo) > (virStorageBackendRBDRefreshPool, virStorageBackendRBDDeleteVol) > (virStorageBackendRBDCreateVol, virStorageBackendRBDRefreshVol) > (virStorageBackendRBDResizeVol): Fix fallout. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > > A quick git grep found no other instances of a '...Ptr' typedef > that wasn't actually a pointer; but I can also add a syntax check > to prevent that mistake if desired.

> > src/storage/storage_backend_rbd.c | 46 +++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) ACK

Daniel