Re: [libvirt] [PATCH 0/5] Add API to tunnel channels
On Thu, Dec 13, 2012 at 11:24:15AM -0500, John Eckersberg wrote:
This series enables the qemu driver to tunnel a virtio channel.
This
is useful for a remote session to communicate with a guest channel via
the streaming API.
This was originally fleshed out a while back in this thread:
https://www.redhat.com/archives/libvir-list/2011-September/msg01049.html
This implements only item (3) in that list.
The new API is nearly identical to the existing virDomainOpenConsole
API, except it works on channels, and supports UNIX sockets in
addition to PTYs for channel source type.
This is my first libvirt patch, please be gentle :)
I've not done a detailed review, but in general it all looks sane
to me. It'll have to wait until after our current pending release
until we in a position to consider applying it though.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|