Re: [libvirt PATCH] tests: add warning that qemucapsprobe prefers native host/guest arch

7 Apr 2021


      On Tue, 2021-04-06 at 12:01 +0100, Daniel P. Berrangé wrote:
...
+++ b/tests/qemucapsprobe.c
@@ -46,6 +46,7 @@ main(int argc, char **argv)
 {
     virThread thread;
     virQEMUCapsPtr caps;
+    virArch guest, host;
I believe it's preferred to declare each variable on its own line,
even though this preference is not spelled out in our coding style.
...
+    if (host != guest)
+        fprintf(stderr,
+                "WARNING: guest architecture '%s' does not match host '%s'.\n"
+                "WARNING: When generating capabilities for the libvirt test\n"
+                "WARNING: suite, it is strongly desired to generate capabilities\n"
+                "WARNING: on the native host to capture KVM related features.\n",
+                virArchToString(guest), virArchToString(host));
Braces around this, please.


Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

    