Re: [libvirt] [PATCH v2 1/3] qemu: refactor graphics code to not hardcode a single display
[snip]
I'd prefer if the refactoring of qemuBuildCommandLine was separated
from
removing the limit for number of graphics cards. But since I already
reviewed
the patch and I don't want to do that again, I'm giving a formal ACK
to this
version (with the small issues fixed, of course).
Since you don't have commit rights, I'll fix the issues and push the
patches.
Thanks for the review, it's all correct, I missed all those returns, and got the
default path wrong - seems libvirtd doesn't mind the no memory report and just
continued, since it didn't affect my testing.
Regarding the split I did leave a second patch that removes the limit check - so the first
patch converts if blocks to a single iteration loop.
Jirka