Re: [libvirt] [PATCH 3/3] gluster: Fix "key" attribute for gluster volumes
On 02/24/14 21:59, Eric Blake wrote:
On 02/24/2014 08:21 AM, Peter Krempa wrote:
> According to our documentation the "key" value has the following
> meaning: "Providing an identifier for the volume which is globally
> unique. This cannot be set when creating a volume: it is always
> generated." The currently used keys for gluster volumes consist of the
> gluster volume name and file path. This can't be considered unique as a
> different storage server can serve a volume with the same name.
>
> Use the full URI as the key for the volume to avoid ambiguity problems.
The full URI cannot be considered unique, either, as both
gluster://hosta/volume/file and gluster://hostb/volume/file may resolve
to the same file. I think we are better off documenting that a key is
This depends on what we consider as "unique" in this context:
The problem you are describing here is that two different keys may map
to a single volume. The issue I'm trying to solve is that one key may
map to two distinct volumes.
As a first step we should thus clarify which way the key should be unique.
If we want to make sure the mapping is always just 1:1, we might want to
choose the gluster volume UUID as the first part of the key instead of
the name.
unique for some pools, but best effort for others, and not change
what
we have already been outputting. But if we DO keep this patch, you also
need to change the documentation that gives examples of gluster keys.
Peter
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)