Re: [libvirt] [PATCH v2 4/9] qemu: Don't add default memballoon device on ARM
On 08/19/2013 01:00 PM, Daniel P. Berrange wrote:
On Sun, Aug 18, 2013 at 02:57:54PM -0400, Cole Robinson wrote:
> And add test cases for a basic working ARM guest.
Does virtio-balloon not work on ARM ? I thought that was an architecture
angostic device type.
It works, but only where virtio-mmio is available, which is not the case for
most ARM boards and any QEMU < 1.6. Given those caveats, I figured it was
better to never auto-add the device.
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 12b68ea..13a3cac 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -8812,7 +8812,6 @@ virDomainVideoDefaultRAM(virDomainDefPtr def,
> }
> }
>
> -
> int
> virDomainVideoDefaultType(virDomainDefPtr def)
> {
> @@ -12147,19 +12146,6 @@ virDomainDefParseXML(xmlDocPtr xml,
>
> def->memballoon = memballoon;
> VIR_FREE(nodes);
> - } else {
> - if (def->virtType == VIR_DOMAIN_VIRT_XEN ||
> - def->virtType == VIR_DOMAIN_VIRT_QEMU ||
> - def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
> - def->virtType == VIR_DOMAIN_VIRT_KVM) {
> - virDomainMemballoonDefPtr memballoon;
> - if (VIR_ALLOC(memballoon) < 0)
> - goto error;
> - memballoon->model = def->virtType == VIR_DOMAIN_VIRT_XEN ?
> - VIR_DOMAIN_MEMBALLOON_MODEL_XEN :
> - VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO;
> - def->memballoon = memballoon;
> - }
This chunk I'd expect in the previous path.
My mistake, I'll fix that in the next repost.
- Cole