Re: [libvirt] [PATCH] Log all errors at level INFO to stop polluting syslog

> This logs at VIR_LOG_ERROR if level is ever out of range (not one of the > 3 defined virErrorLevel values). Can we ever get virErrorLevel set from > external input, or would an out-of-range enum value represent a bug in > our code? If the former, then it may still be worth keeping this > function, and only mapping the three known levels to VIR_LOG_INFO while > keeping all other values as VIR_LOG_ERROR. If the latter, then this > patch seems fine to me. The levels only ever come from our code. In addition every single usage is just VIR_ERR_ERROR, except for 3 places in libvirt.c As such the error levels have no real useful information and it is simplest to ignore them