On 11/23/2010 03:23 AM, Daniel P. Berrange wrote:
This logs at VIR_LOG_ERROR if level is ever out of range (not one of the 3 defined virErrorLevel values). Can we ever get virErrorLevel set from external input, or would an out-of-range enum value represent a bug in our code? If the former, then it may still be worth keeping this function, and only mapping the three known levels to VIR_LOG_INFO while keeping all other values as VIR_LOG_ERROR. If the latter, then this patch seems fine to me.
The levels only ever come from our code. In addition every single usage is just VIR_ERR_ERROR, except for 3 places in libvirt.c As such the error levels have no real useful information and it is simplest to ignore them
Sounds reasonable. Patches that remove more than they add are always fun to justify. ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org