Re: [libvirt] [PATCH] Set default emulator in domain_conf.*, rather than the driver.

Rather than numerous instances of: emulator = vm->def->emulator; if (!emulator) emulator = virDomainDefDefaultEmulator(conn, vm->def, driver->caps); if (!emulator) return -1; Set this value at XML parse time in the domain config, so we can depend on it for all future emulator accesses. There were unchecked accesses in the qemu driver that were tripping up on this if no emulator was specified in the XML, see: http://www.redhat.com/archives/libvir-list/2008-October/msg00602.html Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; --- src/domain_conf.c | 66 ++++++++++++++++++++++++++------------------- src/domain_conf.h | 4 --- src/libvirt_private.syms | 1 - src/lxc_driver.c | 5 --- src/qemu_conf.c | 5 --- src/qemu_driver.c | 8 ----- 6 files changed, 38 insertions(+), 51 deletions(-)