Re: [libvirt] [PATCH 3/3] Add support for shutdown / reboot APIs in LXC driver
> Or is your intent to allow the user to specify multiple flags
> rather than enforcing mutual exclusion between the flags? And
> if so, you need to fix libvirt.c to drop the mutual exclusion,
> as well as to document that when multiple flags are specified,
> it is up to the hypervisor which method is attempted first.
Yep, I think allowing multiple flags is fine at the API level.
I'd do that as a followup commit since it doesn't affect this,
only the existing QEMU code.
In which case, I think this patch is okay as-is (unless you
wanted to follow my other suggestion of refactoring the common
grunt code into a helper method, to reduce code duplication).
ACK.