Re: [libvirt] [PATCH] Fix multiple potential NULL pointer references in monitor usage (v2)

On 05/17/2010 11:41 AM, Daniel P. Berrange wrote:

Any method which intends to invoke a monitor command must have a check for virDomainObjIsActive() before using the monitor to ensure that priv->mon != NULL.

In v2:

- Revert the qemudDomainHotplugVcpus change and add IsActive checks there instead to protect vm->def->vcpus update

Yes, that looks better. ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org