24 May
2011
24 May
'11
11:14 a.m.
On Mon, May 23, 2011 at 04:43:19PM -0600, Eric Blake wrote:
On 05/23/2011 04:26 PM, Jim Fehlig wrote:
b_info->hvm = hvm; b_info->max_vcpus = def->maxvcpus; - b_info->cur_vcpus = def->vcpus; + b_info->cur_vcpus = (1 << def->vcpus) - 1;
That's a compilation pitfall if def->vcpus is exactly 32.
Shoot; xenFormatSxpr in xenxs/xen_sxpr.c has the same bug.
What would be the best way to fix ? cast to a larger int and recast the result or provide some kind of helper function for bitmaps ? Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/