On Wed, May 02, 2012 at 09:04:00PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 6:47 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
What would be these getters apart from the already existing _get_name?
The features under 'guest' can have boolean attributes, 'default' and 'toggle'.
Ah indeed thanks.
According to RNG and examples I have seen so far, 'feature' in the context can't have props but I recall Daniel said on IRC that the RNG is wrong and these nodes can have props too. Any ways, he suggests we keep a class for both 'feature's and I didn't see any harm in that.
I'm not 100% sure what "both" refers to here, since I can see 3 different features, /guest/features, /host/cpu/feature and /host/cpu/features. Given that feature/features are treated the same for host capabilities, I assume you mean having one class for guest features, and one for host CPU features? Works for me, though for the latter, a class wrapping a GList of feature would be less heavyweight, but I'm fine with either approach. Christophe