Re: [libvirt] [PATCH v2 0/7] CPU selection fixes and tests
>> Support for faking emulator in qemuxml2argv tests
>> Tests for CPU selection in qemu driver
>
> Argh, the tests cannot pass if libvirt is not already installed. So maybe it's
> better to move the tests to TCK after all...
Can we run against an uninstalled libvirt? And if so, are we restricted
to the test:///... connection? I'm thinking you are right that the TCK
may be the better fit here.
The problem is not connected to any driver. The reason
why tests fail when run
against uninstalled libvirtd is that cpu_map.xml is not at it's expected place
and cannot be read. Actually it could be solved by adding
cpuMapPath() internal API which would allow to change the path to cpu_map.xml
in runtime. It could actually be useful in the future if we decide to allow
local CPU models to be defined, e.g., in /etc/libvirt/cpu_map.xml.
But while we decide how to handle
test-related commits, I see nothing blocking the non-test patches from
being pushed now.
Thanks. I pushed patches 1 to 5:
Deal with CPU models in []
Move MIN macro to util.h so that others can use it
Support removing features when converting data to CPU
Use configured CPU model if possible
Fake host CPU for qemu tests
Jirka