Re: [PATCH] test_driver: add testUpdateDeviceFlags implementation
On Tue, Jul 02, 2024 at 04:07:48PM +0200, Michal Prívozník wrote:
> + // TODO: support these here once tested.
> + case VIR_DOMAIN_DEVICE_GRAPHICS:
> + case VIR_DOMAIN_DEVICE_NET:
> + case VIR_DOMAIN_DEVICE_MEMORY:
> + virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
> + _("persistent update of device '%1$s' is not
supported by test driver"),
> + virDomainDeviceTypeToString(dev->type));
> + return -1;
> +
It's perfectly okay if ...
> + virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
> + _("persistent update of device '%1$s' is not
supported"),
> + virDomainDeviceTypeToString(dev->type));
.. this error is reported instead.
OK; I just thought it might be useful to separate out "we should add this" from
"we don't support this ever".
> + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE |
> + VIR_DOMAIN_AFFECT_CONFIG |
> + VIR_DOMAIN_DEVICE_MODIFY_FORCE, -1);
LIVE is not supported and thus shouldn't be in list of supported flags.
I was a bit unclear on the test hypervisor case - in a sense everything is both
LIVE *and* CONFIG :)
I'm squashing in necessary changes and merging.
Thanks!
regards
john