[...]
BLOCK_IOTUNE_ASSIGN(SIZE_IOPS_SEC, size_iops_sec);
+ if (*nparams < maxparams && + virTypedParameterAssign(¶ms[(*nparams)++], + VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME, + VIR_TYPED_PARAM_STRING, + reply.group_name) < 0) + goto endjob; +
As Martin pointed out in v1 review , this could still become BLOCK_IOTUNE_ASSIGN, this way it just sort of bothers the OCD inside me. Would you mind adjusting it? :)
I get the OCD thing; however, as I pointed out in my response to Martin the macro uses VIR_TYPED_PARAM_ULLONG while this particular field is a VIR_TYPED_PARAM_STRING
Also, this^^ hunk above will later (during serialization) crash the daemon, since reply is uninitialized in this function so that needs to be adjusted as well.
I'm not getting a libvirtd crash... Do you have a trace? John [...]