Re: [libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function

On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote:

Signed-off-by: Pavel Hrdina <phrdina@redhat.com> --- src/qemu/qemu_snapshot.c | 94 ++++++++++++++++++++++------------------ 1 file changed, 53 insertions(+), 41 deletions(-)

Code change looks reasonable. I'd probably go for a C99-style init of the 'rem' struct. Please provide a commit message and function header documentation outlining what it's supposed to do.