8 Jun
2010
8 Jun
'10
2:46 p.m.
On Tue, Jun 08, 2010 at 12:38:47PM -0600, Eric Blake wrote:
On 06/07/2010 11:23 AM, David Allan wrote:
* This patch is a modification of a patch submitted by Nigel Jones. It fixes several memory leaks on device addition/removal:
1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return value is non-zero
2. Always release the node device reference after the device has been processed.
* Refactored for better readability per the suggestion of clalance
Yes, in comparing the two versions, I can see the improvement. ACK on this version.
-- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
Thanks, pushed. Dave