On 01/13/2015 08:53 AM, Jim Fehlig wrote:
It's been a long, twisting road to V4 of the Xen xl parser. V3
[1] was
based on a flex-based parser that was copied from the Xen project and
proved to be a bit challenging to integrate properly with autotools.
But as it turns out, Xen provides an interface to the parser via libxlutil.
I hadn't realized this interface was available for external consumption
since the corresponding header file was never installed. Patch sent to
xen-devel [2] to install the header, but in the meantime need to declare
gthe imported libxlutil functions as extern (see patch 1).
V4 uses libxlutil, which has simplified the series quite a bit and
eliminates the potential of the copied flex parser diverging from
the canonical source in xen.git.
[1]
https://www.redhat.com/archives/libvir-list/2014-December/msg00765.html
[2]
http://lists.xen.org/archives/html/xen-devel/2015-01/msg00690.html
Yay - this series compiled on RHEL 5, with no extra efforts on my part.
I'll review the individual patches as well, but we're already looking
better.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org