Re: [libvirt] [PATCH 1/2] qemu: Add missing lock of virDomainObj before calling virDomainUnref

I think the real reason for the deadlock is that: qemudDomainSaveFlag holds the domain lock while it calls qemuDomainEventQueue, which requests the event loop lock the event loop thread holds the event loop lock, and can make several different callbacks that can result in requesting a domain lock I counted 29 callers of qemuDomainEventQueue; the majority of those were in situations where the domain lock had already been dropped (in fact, it makes sense to generate the event while you own the domain, but wait to fire it off until after you are done with the domain).

But the rest could probably use a helper method that increases the vm ref count, unlocks the domain lock, fires the event, grabs the domain lock, reduces the vm ref count, and checks that the domain is still active.