4 Apr
2017
4 Apr
'17
8:06 a.m.
On Tue, 2017-04-04 at 13:50 +0200, Peter Krempa wrote:
+#undef DO_TEST_GLUSTER_LOOKUP_NATIVE +#undef DO_TEST_GLUSTER_LOOKUP_NETFS +#undef DO_TEST_GLUSTER_LOOKUP_FULL
The #undefs are a bit unnecessary in this context, I'd leave them out.
It's true that it would be hard to use these somewhere else (since they are in a .c file) but ad-hoc macros should be undefined. Otherwise they are not ad-hoc and should bear the VIR_ prefix.
Feel free to leave the hunk in then :) -- Andrea Bolognani / Red Hat / Virtualization