Re: [libvirt] [PATCHv2 0/2] Boot options cleanup
On 02/25/2015 10:40 AM, Peter Krempa wrote:
On Wed, Feb 25, 2015 at 09:17:27 -0500, John Ferlan wrote:
> On 02/25/2015 07:52 AM, Ján Tomko wrote:
...
>>
>
> ACK both
>
> If I understand the rules of the road correctly... Since the original
> series was reviewed prior to the freeze and this just adjust that, it
> seems reasonable to say it's OK for freeze...
Actually I'd rather not codify that as a rule. After the freeze
everythling should be re-evaluated if it makes sense actually to push.
Purpose of the freeze is not to limit new features appearing but have a
line where stuff that is likely to break the comming release in any way
to be limited.
If you get a review for a big feature prior to the freeze and then send
a few patches after the freeze it will not make them automagically
appear in the RC-package or any less likely to break the release.
I think only fixes that target code that was touched in the last devel
cycle or fix a obvious bug in a common path should be taken, otherwise
we might as well as not have any freeze.
Hmm.. perhaps let me clarify my thoughts... These are bug fix patches
which I had differentiated in my mind compared to patches for some
feature addition when I wrote the above.
Whether as a general rule of thumb we as a group adhere to your last
paragraph regarding last devel cycle perhaps has a lot more to do with
the ability to provide timely patch reviews when everyone is trying to
submit patches to "beat" the freeze date and performing fewer reviews
until after that date (especially in this global development cycle where
times and dates are relative to your location).
For this sequence of patches, the original patches were posted 2/18... I
reviewed 2/23... Freeze 2/24... These changes were posted 2/25 as a
reaction to review comments. Could they wait - sure... But it seems they
are no less safe/harmful than some other patches taken after freezes in
my historical recollection...
John