Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal
On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote:
Only succeed when @pid_value is 1, since according to the docs this
is
the minimum requirement for any driver to implement this API.
>From man 2 kill:
The only signals that can be sent to process ID 1, the init process, are
those for which init has explicitly installed signal handlers.
Regarding sending SIGTERM and SIGKILL to init, the test driver domains
pretend to run Linux, and on Linux init/systemd explicitly ignores these
signals.
I don't thing the previous 2 paragraphs are needed, I think that stating
"Since this is test driver, we assume that any signal from the supported list
can be sent to pid 1 and we therefore succeed every time" is sufficient.
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>