[ OOPs actually I wrote this reply wednesday last week but forgot to send it, sorry , Daniel ] On Mon, Mar 28, 2011 at 05:13:46PM +0900, Naoya Horiguchi wrote:
Currently libvirt's logging is so poor that it's difficult to determine what was happening when a proglem occurred (especially on someone's
Actually libvirt logging is fairly complete, but the default logging at the INFO level is not complete, which can be a problem for a prosteriori analysis. http://libvirt.org/logging.html I tried to fix this for serious problems like crashes https://www.redhat.com/archives/libvir-list/2011-March/msg00072.html but for continuous default logging, yeah we could be a bit more verbose
machines you don't know the detail.) This patch helps us to do that by making additional logging available for the following events:
creating/defining/undefining domains creating/defining/undefining/starting/stopping networks creating/defining/undefining/starting/stopping storage pools creating/defining/undefining/starting/stopping storage volumes.
Okay, makes sense to me. ACK,
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> --- src/network/bridge_driver.c | 4 ++++ src/qemu/qemu_driver.c | 5 ++++- src/storage/storage_driver.c | 12 ++++++++++++ 3 files changed, 20 insertions(+), 1 deletions(-)
diff --git v0.8.8/src/network/bridge_driver.c v0.8.8/src/network/bridge_driver.c
Note: your patch didn't applied cleanly because you developped it against a released versions, it's better to do this against libvirt git head. I rebased it solving the couple of conflict, it was easy, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/