Re: [libvirt] [RFC PATCH 00/12] qemu: add support to hot-plug/unplug cpu device

On Wed, Jan 21, 2015 at 16:00:52 +0800, Zhu Guihua wrote: Libvirt already implements vCPU hotplug and unplug via virDomainSetVcpusFlags() API and implements this API also for the qemu driver. Granted that the existing code uses older comands but that can be tweaked to support the new stuff too. Additionally the new <cpu> subelement of <devices> doesn't seem necessary: - There's only one model that can be plugged - Configuring the APIC id doesn't make much sense for users - nothing else can be configured I have following questions though: Is there a difference in specifying the cpu via the -device option and via the legacy -cpu argument? Is there a plan to have more than one cpu "model" that can be plugged? Can more than one cpu model be plugged to the same VM at the same time? In general I don't think it's necessary to add the new device type and we should rather improve the existing API to support the new device type. More comments will be inline in the patches. Peter