Re: [libvirt] [PATCH] virtperf: Revert PERF_COUNT_HW_REF_CPU_CYCLES conditional
Am Tue, 14 Mar 2017 14:05:37 +0100
schrieb Martin Kletzander <mkletzan(a)redhat.com>:
However without that commit we'll be back to broken code that
won't compile on some distros. So unless I missed something (if I did, it should be
added to the commit message), there should rather be a configure check that defines
something similar to other code, e.g. HAVE_PERF_CPU_CYCLES and then that should be used in
the conditional.
There are other places in that and other files which can not be compiled. The obvious fix
is to just add a #ifndef x;#define x 0 to get libvirt going. The question is still
unanswered if configure should just error out and refuse to go further, or if the few
missing pieces should be supplied manually because the affected functionality is
optional.
See attached patches for how I deal with it.
Olaf
Attachments:
- attachment.sig (application/pgp-signature — 195 bytes)
- libvirt-perf.patch (text/x-patch — 523 bytes)
- libvirt-mount.patch (text/x-patch — 613 bytes)