On 04/13/2011 12:14 PM, Daniel P. Berrange wrote:
Replace cases of
type = virConnectGetType(conn);
if (type == NULL)
goto cleanup;
With
if (!(type = virConnectGetType(conn)))
goto cleanup;
* daemon/remote.c: Write error checks in compat form
---
daemon/remote.c | 795 +++++++++++++++++++------------------------------------
1 files changed, 278 insertions(+), 517 deletions(-)
Not quite a 1:2 ration in + to -, but still fairly mechanical.
Didn't spot anything obviously wrong. I did see at least one variable
rename (from err to int) snuck in; but that's okay.
ACK.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org