Re: [libvirt] [PATCH V1 4/5] uuid: fix possible non-terminated string

On 05/04/2012 05:54 AM, Stefan Berger wrote: > Error: STRING_NULL: > /libvirt/src/util/uuid.c:273: > string_null_argument: Function "getDMISystemUUID" does not terminate string "*dmiuuid". > /libvirt/src/util/uuid.c:241: > + rc = getDMISystemUUID(dmiuuid, sizeof(dmiuuid) - 1); This is working around the issue in the caller; wouldn't a better fix be to actually alter getDMISystemUUID to guarantee NUL termination in the first place, so that we don't have to audit all callers?