On Tue, Apr 07, 2015 at 09:23:16AM -0400, John Ferlan wrote:
Future IOThread setting patches would copy the code anyway, so create and generalize a delete cgroup and pindef for the vcpu into its own API.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/qemu/qemu_driver.c | 43 +++++++++++++++++++++++++++++-------------- 1 file changed, 29 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1114ce9..cec2758 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4670,6 +4670,30 @@ qemuDomainHotplugAddCgroup(virCgroupPtr cgroup, }
static int +qemuDomainHotplugDelCgroupPin(virCgroupPtr cgroup,
qemuDomainDelCgroupForThread
+ virCgroupThreadName nameval, + int index,
+ virDomainPinDefPtr **pindef_list, + size_t *npin)
I think the pin deletion should be separate from this function. These arguments would not be needed then. ACK with those two changes. Jan