On 01/14/2011 10:35 AM, Laine Stump wrote:
The sndbuf value is put inside a <tune> element of each <interface> in the domain. The intent is that further tunable settings will also be placed inside this element.
<interface type='network'> ... <tune> <sndbuf>0</sndbuf> ... </tune> </interface> ---
Changes from V1:
sndbuf_specified is now a bool rather than an int bitfield.
sndbuf is now unsigned long. Made possible by eblake's patch adding new virXPath* and virStrToLong_* functions.
Glad to hear it :)
+ if (virXPathULong("string(./tune/sndbuf)", ctxt, &def->tune.sndbuf) >= 0) { + def->tune.sndbuf_specified = true; + }
This silently ignores invalid values, such as <sndbuf>-1</sndbuf>, rather than flagging them as errors. Is that intentional? ACK, with that nit addressed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org