Re: [libvirt] [PATCHv2 2/9] virNodeGetCPUMapFlags: Define driver API.
On 10/23/2012 01:17 PM, Eric Blake wrote:
On 10/23/2012 12:12 PM, Eric Blake wrote:
> On 10/16/2012 08:05 AM, Viktor Mihajlovski wrote:
>> Extend the driver structure by nodeGetCPUMapFlags entry in support of the
>> new API virNodeGetCPUMapFlags.
>>
>> Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.vnet.ibm.com>
>> ---
>> src/driver.h | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> This patch belongs squashed with 1/9.
Also, this patch in isolation fails 'make check':
make[2]: Entering directory `/home/remote/eblake/libvirt/docs'
GEN hvsupport.html.in
driver NodeGetCPUMap does not have a public API at ./hvsupport.pl line
165, <FILE> line 1096.
All the more reason to squash things together.
Never mind; this one was a case of me failing to remove enough 'Flags'
in patch 1:
diff --git i/python/generator.py w/python/generator.py
index 8591b8d..c76ff2a 100755
--- i/python/generator.py
+++ w/python/generator.py
@@ -429,7 +429,7 @@ skip_impl = (
'virConnectRegisterCloseCallback',
'virNodeGetMemoryParameters',
'virNodeSetMemoryParameters',
- 'virNodeGetCPUMapFlags',
+ 'virNodeGetCPUMap',
)
qemu_skip_impl = (
diff --git i/src/libvirt_public.syms w/src/libvirt_public.syms
index 0c8f4ff..f494821 100644
--- i/src/libvirt_public.syms
+++ w/src/libvirt_public.syms
@@ -571,7 +571,7 @@ LIBVIRT_0.10.2 {
LIBVIRT_1.0.0 {
global:
- virNodeGetCPUMapFlags;
+ virNodeGetCPUMap;
} LIBVIRT_0.10.2;
# .... define new API here using predicted next version number ....
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 617 bytes)