Re: [libvirt] [PATCH v2 1/2] conf: add xml element devices/pvpanic
On 12/04/2013 08:42 AM, Daniel P. Berrange wrote:
> Dan, do you have any thoughts on the best representation to use?
Or is
> Hu's original proposal of:
>
> <pvpanic ioport='0x505'/>
I'm not a fan of doing a special case attribute for 'ioport' - this is
something something that should be part of an <address> element, since
ioport numbers are a generic addressing concept for many devices.
eg ISA serial / parallel ports have IRQ / IO ports IIUC.
So something more like:
<pvpanic>
<address type='ioport' slot='0x505'/>
</pvpanic>
and introducing a new type='ioport' namespace into the <address> XML
since it is yet another numbering system for guest-visible addressing?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)