Re: [libvirt] [PATCH] util: remove unneeded #include in virrandom.c
On Thu, Mar 01, 2012 at 10:25:11AM -0700, Eric Blake wrote:
On 03/01/2012 09:53 AM, Daniel P. Berrange wrote:
> On Thu, Mar 01, 2012 at 11:43:04AM -0500, Laine Stump wrote:
>> Commit 7c90026 added #include "conf/domain_conf.h" to
>> util/virrandom.c. Fortunately it didn't actually use anything from
>> domain_conf.h, since as far as I'm aware, files in util aren't allowed
>> to reference anything in conf (although the opposite is allowed). So
>> this #include is unnecessary.
>
> That is correct. util/ must be self-contained
Guess what - that sounds like a great syntax rule to write, so we don't
slip up in the future. Give me a few minutes, to see what I can come up
with. Any other directories that should be avoiding particular includes?
conf/ should only depend on util/
locking/ & security/ should only depend on conf/ & util/
And esx/hyperv/interface/network/etc should not depend
on each other
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|