Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests
On Fri, Jul 21, 2017 at 10:39:05 +0200, Andrea Bolognani wrote:
On Fri, 2017-07-21 at 10:07 +0200, Andrea Bolognani wrote:
[...]
> That makes sense.
>
> Doesn't it also mean that we don't really need to record
> whether the user set the model name explicitly or not? We
> can just skip formatting it if it's spapr-pci-host-bridge
> and all versions of libvirt, past or future, will handle
> that correctly.
Wait, that's exactly how this patch behaves, except it's
not immediately apparent because the check for the model
name happens inside virDomainControllerIsPCIHostBridge()
rather than being explicit.
So maybe I'm still missing something?
You are right. The not-formatting only the first model ever added should
be fine in this case also in the future.
Please send a fixed version of this patch that will make sure that it
states that the PHB thing is a pSeries thing, so that it does not
confuse others as it did me.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)