On 01/13/15 18:20, Michal Privoznik wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1180955
Up till now, there was only one format for UEFI and NVRAM store file. However, it's possible to convert the files to qcow2 (which supports interesting features, like snapshotting, for instance). Therefore, we want to allow format selection over the UEFI and NVRAM store file. By default, the format is raw, but users can choose qcow2. In the domain XML this is expressed as @format attribute to <loader/> and <nvram/> elements.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- docs/formatdomain.html.in | 18 +++++++--- docs/schemas/domaincommon.rng | 16 +++++++++ src/conf/domain_conf.c | 34 ++++++++++++++++-- src/conf/domain_conf.h | 11 ++++++ src/libvirt_private.syms | 2 ++ .../qemuxml2xmlout-bios-nvram.xml | 40 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 +- 7 files changed, 116 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram.xml
Looks good to me. Acked-by: Laszlo Ersek <lersek@redhat.com>