Re: [libvirt] [PATCH] maint: drop spurious semicolons
On 08/25/2014 08:52 PM, Martin Kletzander wrote:
On Mon, Aug 25, 2014 at 04:31:07PM -0600, Eric Blake wrote:
> I noticed a line 'int nparams = 0;;' in remote_dispatch.h, and
> tracked down where it was generated. While at it, I found a
> couple of other double semicolons. Additionally, I noticed that
> commit df0b57a95 left a stale reference to the file name
> remote_dispatch_bodies.h.
>
>
> Syntax check can't easily catch this, because we want to allow
> 'for (int i = 0;; i++)' on a loop that uses break to exit, so
> this is just done by manual inspection.
>
But trying ';;$' it looks like it can. And trying it out it seems
there's still one place left.
Oh cool, looks like I have a followup patch to write, then.
And after your patch:
git ls-files | grep '\.[chx]' | xargs grep ';;$'
src/xenconfig/xen_common.c: return -1;;
Martin
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 539 bytes)