Re: [libvirt] [PATCH v1 01/14] conf: Fix virDomainDeviceGetInfo const correctness

On Thu, Oct 19, 2017 at 10:10:56AM +0200, Michal Privoznik wrote: Is there any other reason for this then just your new code using const? I don't see any pointer that's passed through your later code that would be const nowadays, so why would we play the const-correctness game here when it doesn't make much sense in C when the pointer is to a struct since the const doesn't propagate? If s/const virDomainDeviceDef/virDomainDeviceDef/ on your later patch makes this one unnecessary, then NACK to this. If there is a reason, however, feel free to keep this in.