Re: [libvirt] [PATCH v2 4/5] bhyve: implement bhyve argument parser

> > Extra break; >> + break; >> + case 'I': >> + /* While this flag was deprecated in FreeBSD r257423, keep checking >> + * for it for backwards compatibility. */ >> + def->features[VIR_DOMAIN_FEATURE_APIC] = VIR_TRISTATE_SWITCH_ON; >> + break; >> + case 'u': >> + if ((caps & BHYVE_CAP_RTC_UTC) != 0) { >> + def->clock.offset = VIR_DOMAIN_CLOCK_OFFSET_UTC; >> + } else { >> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", >> + _("Installed bhyve binary does not support " >> + "UTC clock")); >> + goto error; >> + } > > I'm wondering if it actually makes sense to throw an error here? I mean, > if a user had this flag, most likely it's supported by that bhyve binary > and in unlikely case if it's not, there will be an error thrown anyway, > but at the later stage. True, but why not? I'm guessing a potential use case for this might not just be using native command strings from the same host, but I may be mistaken.