Re: [Libvir] Repository for work-in-progress storage patches

"Daniel P. Berrange" <berrange@redhat.com> wrote: ... Since you're working on the weekend ;-), here are some notices I'd begun to accumulate: There are a bunch of new uses of open64, which isn't portable. How about using AC_SYS_LARGEFILE in configure.in instead? Then you can use "open" everywhere. In storage_backend_loop.c, it looks like vol->target.path can be leaked. Just after that, I wondered if other vol->members could be leaked, but haven't yet looked at the cleanup-called vol-destroying function; it probably frees everything.