16 Nov
2018
16 Nov
'18
1:38 p.m.
On Fri, Nov 16, 2018 at 05:21:31PM +0100, Andrea Bolognani wrote:
virXMLFormatElement() might fail, but we were not checking its return value.
Fixing this requires us to change virDomainDeviceInfoFormat() so that it can report an error back to the caller.
Introduced-by: 0d6b87335c00451b0923ecc91d617f71e4135bf8 Spotted-by: Coverity Reported-by: John Ferlan <jferlan@redhat.com> Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- src/conf/domain_conf.c | 97 ++++++++++++++++++++++++++++-------------- 1 file changed, 66 insertions(+), 31 deletions(-)
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>