6 Sep
2012
6 Sep
'12
11:53 p.m.
On 09/06/2012 03:43 PM, Peter Krempa wrote:
On 09/05/12 07:34, Osier Yang wrote:
output of commands like '%virsh nodedev-list --tree --cap pci' could be empty.
The moment you introduce filtering, --tree output no longer makes sense (if a child has --cap pci but the parent does not, then you've lost tree output). I'd much rather have a patch that rejects the virsh command up front if --tree is mixed with --cap, as the command no longer makes sense.
NACK to this patch as it breaks the output.
I agree with the NACK and that a different approach is needed. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org