Re: [libvirt] [PATCHv2] utils: Remove the logging of errors from virNetDevSendEthtoolIoctl
On 08/18/2015 04:58 PM, Moshe Levi wrote:
This patch remove the logging of errors of ioctl api and instead
let the caller to choose what errors to log
---
src/util/virnetdev.c | 56 ++++++++++++++-----------------------------------
1 files changed, 16 insertions(+), 40 deletions(-)
Sorry for the delay - last week was KVM Forum and I'm finally mostly
caught up with my emails..
Anyway, this looks a whole lot better than before and "no different"
than before where if virNetDevSendEthtoolIoctl returned failure the
callers to virNetDevFeatureAvailable and virNetDevGFeatureAvailable
still make their virBitmapSetBit calls regardless of whether the call
returns 1 or -1. That's (more or less) what Jan and Laine discussed in
their review of Laine's similar changes.
Anyway, I asked Laine to take a peek before I pushed...
John
I suppose my one hangup is the EOPNOTSUPP which would seemingly need to
be "handled" at some point in the future "if" there is filtering and
only because I'm not completely convinced whether someone could be
running on an older kernel where perhaps one of the cmd bits isn't
available (yet). I guess that will be revealed in followup patches!