Re: [libvirt] [PATCH v1 01/18] add macros for implementing automatic cleanup functionality

On Sun, Jun 03, 2018 at 01:41:59PM +0530, Sukrit Bhatnagar wrote: > New macros are added to src/util/viralloc.h which help in > adding cleanup attribute to variable declarations. > > Signed-off-by: Sukrit Bhatnagar <skrtbhtngr(a)gmail.com&gt; If you recall the recent RFC thread [1], I agreed with Pavel that we should introduce complete changes to each file, so that we don't need to track was has been already done for what file and what is still missing, so the series would look something like this: 1) vir<some_file>.c preparations (especially VIR_{AUTOPTR,AUTOCLEAR} might need that) 2) Use VIR_AUTOFREE across vir<some_file>.c 3) Use VIR_AUTOPTR across vir<some_file>.c 4) Use VIR_AUTOCLEAR across vir<some_file>.c ...One more thing, the commit subject of every patch in the current series should probably look like this: util: <module>: Use VIR_AUTOFREE instead of VIR_FREE for scalar types and the corresponding commit message: By making use of the GCC's __attribute__((cleanup)) handled by VIR_AUTOFREE macro, majority of the VIR_FREE calls can be dropped, which in turn leads to getting rid of most of our cleanup sections. [1] https://www.redhat.com/archives/libvir-list/2018-May/msg02391.html