Re: [libvirt] [PATCH go-xml v2] Add support for QEMU

Add support for QEMU, and add test code. Signed-off-by: Thomas Hipp <thipp(a)suse.de&gt; --- Changes since v1: - support multiple Args and Envs --- domain.go | 50 +++++++++++++++++++++++++++++++++----------------- domain_test.go | 28 ++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+), 17 deletions(-) diff --git a/domain.go b/domain.go index b9b0f77..8c1fa76 100644 --- a/domain.go +++ b/domain.go @@ -590,27 +590,43 @@ type DomainFeatureList struct { SMM *DomainFeatureState `xml:"smm"` } +type DomainQEMUCommandlineArg struct { + Value string `xml:"value,attr"` +} + +type DomainQEMUCommandlineEnv struct { + Name string `xml:"name,attr"` + Value string `xml:"value,attr,omitempty"` +} + +type DomainQEMUCommandline struct {

+ Args []DomainQEMUCommandlineArg `xml:"qemu arg"`

+ Envs []DomainQEMUCommandlineEnv `xml:"qemu env"`

+}

+ // NB, try to keep the order of fields in this struct // matching the order of XML elements that libvirt // will generate when dumping XML. type Domain struct {

+ QEMUCommandline *DomainQEMUCommandline `xml:"qemu commandline"`

}