Re: [libvirt] [PATCH 0/5] Fill qemucapabilitiesdata with some data

On 10/03/2013 07:25 AM, Michal Privoznik wrote: While trying to backport this series, I noticed that: these .replies files are very hard to modify, when using a newer or older version of libvirt that issues more or fewer JSON commands (that is, the replies file is hardcoded to giving answers in the same order as libvirt asks questions, but if the set or order of questions changes, it's hard to see which answer(s) needs changing). I would suggest that we update the files to add a comment describing the JSON command issued prior to each reply; the test should filter out the comments. Doing this will make it easier to modify the .replies files in the future if we tweak qemu_capabilities.c to trigger more JSON commands even for older qemu responses. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org