Re: [libvirt] [PATCH] virDomainSaveXML: Reject domains which name contain '/'
On 02/05/2013 08:54 AM, Michal Privoznik wrote:
> I think you understate the benefits here. UUID based filenames
are just
> absolutely *ing horrific for an admin to see and work work and I am very
> glad libvirt does not use such a naming scheme.
>
> Daniel
>
But we discourage users to touch /etc/libvirt/qemu/*.xml files anyway.
Moreover, we advise to define domain by not copying the files but using
libvirt APIs.
It's not just /etc/libvirt/qemu/*.xml. It's also
/var/log/libvirt/qemu/*.log. And while we don't mind telling people to
leave /etc alone, we actively encourage people to use /var/log, and
anything we can do to make the logs more usable (names instead of uuids)
is worth it.
I'm in full agreement with this patch, but think it doesn't go far
enough; we probably also want to forbid domain names with a leading '.'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)