Re: [libvirt] consistency of virsh help output

On 02/03/2011 02:31 AM, Zdenek Styblik wrote: While I agree that a patch to make things more consistent is probably worthwhile, I was unclear from your report on which way you thought things should be changed. In this case, patches speak louder than words :) Did you have in mind changing the synopsis to match the options? attach-disk [--domain] <string> [--source] <string> [--target] <string> [--driver <string>] or were you thinking of making the synopsis even more compact? attach-disk <domain> <source> <target> [<driver>] or are you thinking of changing the layout in options? Remember, the goal is to convey which parameters are required (but which can still be specified out of order by using the optional --flag prefix), vs. which parameters are optional (and therefore require a --flag prefix to make it obvious which optional parameter is being provided), while also being clear on which optional parameters require an argument (and whether that argument is text or numeric) vs. those that are just boolean flags. That's true - the option printing is all controlled in tools/virsh.c:vshCmddefHelp. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org