Re: [PATCH v1] virtqemud: remove sysconfig file
Am Mon, 19 Jul 2021 09:55:37 +0100
schrieb Daniel P. Berrangé <berrange(a)redhat.com>:
I don't see that would have made any change since --listen was
not enabled
either before / after the changes.
It was the default in the SUSE package.
I should have checked libvirt.git if it has been used.
Originally the sysconfig file provided a way to override the
initscripts
config, and was kept with systemd units essentially because it already
exists. Now that initscripts are completely gone, the sysconfig possibly
doesn't need to exist, as it is already posible to override unit files in
a reasonably simple manner.
I have seen sysv scripts that do "test -f sysconfig/file && . $_", so in
some
sense sysconfig was already optional before. I have not checked if the sysv
scripts from libvirt.git had such code.
So, do you or anyone else agree to get rid of sysconfig files in libvirt.git
and put the defaults provided by libvirt.git into the systemd unit files?
Just as I proposed in my patch?
If yes, should it be one monolithic change that touches also libvirt.spec
and the NEWS file?
Olaf
Attachments:
- attachment.sig (application/pgp-signature — 833 bytes)