On Wed, 2017-03-15 at 15:22 -0400, Laine Stump wrote:
It was mentioned somewhere, at some point, that we might want to switch to generic PCIe Root Ports for x86/q35 guests as well. It sounds like a good idea to me, and in fact QEMU's sample configuration files for x86/q35 (docs/q35-virtio-*.cfg) already push in that direction; however, I didn't want to risk holding up the aarch64/virt change, which we unquestionably want, because of that, so I will propose it as a separate patch further down the line. Personally I'm fine with making it the default for new root ports on any machinetype that has it in the capabilities - if anything doesn't work, it's a bug and needs to be fixed, and we can't find the things that don't work if people aren't using it. In other words "the sooner the better". (Aside from that is the fact that the generic root port is going to have IO space turned off by default, and we should all be switching to that as soon as possible).
I agree with you, let's just change the default for all architectures and machine types in one fell swoop. -- Andrea Bolognani / Red Hat / Virtualization